From: Florian Müllner Date: Fri, 19 Feb 2010 00:42:09 +0000 (+0100) Subject: Show/hide the summary during the overview transition X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~10428 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=1b7c3580e69215b7676640235f321441e502c248;p=gnome-shell.git Show/hide the summary during the overview transition Right now, the summary starts popping up when the overview has been shown and starts to disappear when the overview is hidden. Instead, animate the summary during the overview transition. https://bugzilla.gnome.org/show_bug.cgi?id=610520 --- diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 7cab84391..039685a1c 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -377,6 +377,7 @@ MessageTray.prototype = { this._pointerInSummary = false; this._notificationState = State.HIDDEN; this._notificationTimeoutId = 0; + this._overviewVisible = false; this.actor.show(); Main.chrome.addActor(this.actor, { affectsStruts: false, @@ -387,8 +388,16 @@ MessageTray.prototype = { Lang.bind(this, this._setSizePosition)); this._setSizePosition(); - Main.overview.connect('shown', Lang.bind(this, this._updateState)); - Main.overview.connect('hidden', Lang.bind(this, this._updateState)); + Main.overview.connect('showing', Lang.bind(this, + function() { + this._overviewVisible = true; + this._updateState(); + })); + Main.overview.connect('hiding', Lang.bind(this, + function() { + this._overviewVisible = false; + this._updateState(); + })); this._sources = {}; this._icons = {}; @@ -528,7 +537,7 @@ MessageTray.prototype = { } // Summary - let summarySummoned = this._pointerInSummary || Main.overview.visible; + let summarySummoned = this._pointerInSummary || this._overviewVisible; let summaryPinned = this._summaryTimeoutId != 0 || this._pointerInTray || summarySummoned; let notificationsVisible = (this._notificationState == State.SHOWING || this._notificationState == State.SHOWN);